Review Request 121692: Implement a plugin for the inhibition of the screensaver when a device is connected

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121692/#review72639
-----------------------------------------------------------


I like the idea. Maybe it would make sense to have it as an opt-in option?

Also have you thought of all use-cases? What happens if you close the laptop lid? Will it inhibit then as well?

- Aleix Pol Gonzalez


On Dec. 28, 2014, 10:31 a.m., Pramod Dematagoda wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121692/
> -----------------------------------------------------------
> 
> (Updated Dec. 28, 2014, 10:31 a.m.)
> 
> 
> Review request for kdeconnect and Albert Vaca Cintora.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> This plugin serves to inhibit the screensaver when enabled for a given device and that device is connected to kdeconnect. The inhibition is lifted when the plugin is either disabled or the device disconnects from kdeconnect.
> 
> 
> Diffs
> -----
> 
>   plugins/CMakeLists.txt de1131d 
>   plugins/screensaver-inhibit/CMakeLists.txt PRE-CREATION 
>   plugins/screensaver-inhibit/README PRE-CREATION 
>   plugins/screensaver-inhibit/kdeconnect_screensaver_inhibit.desktop PRE-CREATION 
>   plugins/screensaver-inhibit/screensaverinhibitplugin.h PRE-CREATION 
>   plugins/screensaver-inhibit/screensaverinhibitplugin.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/121692/diff/
> 
> 
> Testing
> -------
> 
> Simple testing where a phone with kdeconnect is connected to a laptop with the proposed patch and it is observed that the screensaver does not start with the phone connected and the plugin enabled. The screensaver does start with the plugin either disabled or when the phone is disconnected.
> 
> 
> Thanks,
> 
> Pramod Dematagoda
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20141228/cc3ae350/attachment.html>