Review Request 122294: Improve cppcheck configuration for kdevplatform.

[Marko Käning]

> On Jan. 28, 2015, 7:54 p.m., Marko Käning wrote:
> > I have tried to use this configuration on my OSX/CI system, but I ran into this:
> > ```
> > == Executing cppcheck
> > 
> > Traceback (most recent call last):
> >   File "tools/perform-build.py", line 75, in <module>
> >     manager.execute_cppcheck()
> >   File "/Users/marko/scripts/tools/kdecilib.py", line 925, in execute_cppcheck
> >     command = command.format( cpuCount=cpuCount, sources=self.projectSources, buildDirectory=buildDirectory )
> > KeyError: 'sourceRoot'
> > ```
> > So, it looks like my systme isn't set up properly for cppcheck at the moment.
> > (Strange, as I was in the believe that it did work in the past...)
> 
> Milian Wolff wrote:
>     Maybe the line is incorrect, I just hoped that {sourceRoot} points to the root of the kdevplatform source directory. See e.g. in global.cfg:
>     
>         covBuildCommand=%(covBuildExecutable)s --dir {sourceRoot}/cov-int python tools/coverity-builder.py --sourceRoot {sourceRoot} --platform {platform}

Milian, just replace {sourceRoot} against {source} and you should be fine. It's a bug in covBuildCommand!!!

Here on OSX/CI it ran through:
```
MVM2:scripts marko$ ./install.sh kdevplatform rebuild
------------------------------------------
Group    : kf5-qt5
Project  : extragear/kdevelop/kdevplatform
Branch   : master
Linux-CI : UNSTABLE
OSX/CI   : FAILURE
Prep...  
Build... : SUCCESS
==========================================
```
:-)

This [docu written by Ben](http://quickgit.kde.org/?p=websites%2Fbuild-kde-org.git&a=blob&h=f4e0cd7fcafe61b431ab6b6a77ef21efae27d4bc&hb=f2d024f155bed23a9e81b0175e5c7d752d6d8f14&f=documentation%2Fjob-execution.txt) helped me figuring it out.


- Marko


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122294/#review74936
-----------------------------------------------------------


On Jan. 28, 2015, 8:09 p.m., Milian Wolff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122294/
> -----------------------------------------------------------
> 
> (Updated Jan. 28, 2015, 8:09 p.m.)
> 
> 
> Review request for KDE Websites, Ben Cooksley, Marko Käning, and Scarlett Clark.
> 
> 
> Repository: build-kde-org
> 
> 
> Description
> -------
> 
> Add more macros and ignore file templates that are invalid C++.
> 
> Add reviewboardrc file
> 
> REVIEW: 122294
> 
> 
> Diffs
> -----
> 
>   .reviewboardrc PRE-CREATION 
>   config/build/kdevplatform/kf5-qt5.cfg 0d82fce44699817baeeb0b8a6126b8da96cdcc43 
> 
> Diff: https://git.reviewboard.kde.org/r/122294/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Milian Wolff
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-www/attachments/20150128/f00a9592/attachment-0001.html>