<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122294/">https://git.reviewboard.kde.org/r/122294/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 28th, 2015, 7:54 p.m. CET, <b>Marko Käning</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I have tried to use this configuration on my OSX/CI system, but I ran into this:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%"><span style="color: #666666">==</span> Executing cppcheck
Traceback (most recent <span style="color: #008000">call</span> <span style="color: #008000">last</span>):
<span style="color: #008000">File</span> <span style="color: #BA2121">"tools/perform-build.py"</span>, <span style="color: #008000">line</span> <span style="color: #666666">75</span>, <span style="color: #008000; font-weight: bold">in</span> <span style="color: #666666"><</span>module<span style="color: #666666">></span>
manager.execute_cppcheck()
<span style="color: #008000">File</span> <span style="color: #BA2121">"/Users/marko/scripts/tools/kdecilib.py"</span>, <span style="color: #008000">line</span> <span style="color: #666666">925</span>, <span style="color: #008000; font-weight: bold">in</span> execute_cppcheck
command <span style="color: #666666">=</span> command.format( cpuCount<span style="color: #666666">=</span>cpuCount, sources<span style="color: #666666">=</span><span style="color: #008000">self.</span>projectSources, buildDirectory<span style="color: #666666">=</span>buildDirectory )
KeyError: <span style="color: #BA2121">'sourceRoot'</span>
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">So, it looks like my systme isn't set up properly for cppcheck at the moment.
(Strange, as I was in the believe that it did work in the past...)</p></pre>
</blockquote>
<p>On January 28th, 2015, 8:13 p.m. CET, <b>Milian Wolff</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Maybe the line is incorrect, I just hoped that {sourceRoot} points to the root of the kdevplatform source directory. See e.g. in global.cfg:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">covBuildCommand<span style="color: #666666">=%</span>(covBuildExecutable)s <span style="color: #666666">--</span>dir {sourceRoot}<span style="color: #666666">/</span>cov<span style="color: #666666">-</span><span style="color: #B00040">int</span> python tools<span style="color: #666666">/</span>coverity<span style="color: #666666">-</span>builder.py <span style="color: #666666">--</span>sourceRoot {sourceRoot} <span style="color: #666666">--</span>platform {platform}
</pre></div>
</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Milian, just replace {sourceRoot} against {source} and you should be fine. It's a bug in covBuildCommand!!!</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Here on OSX/CI it ran through:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">MVM2<span style="color: #666666">:</span>scripts marko$ <span style="color: #666666">./</span>install<span style="color: #666666">.</span><span style="color: #7D9029">sh</span> kdevplatform rebuild
<span style="color: #666666">------------------------------------------</span>
Group <span style="color: #666666">:</span> kf5<span style="color: #666666">-</span>qt5
Project <span style="color: #666666">:</span> extragear<span style="color: #BB6688">/kdevelop/</span>kdevplatform
Branch <span style="color: #666666">:</span> master
Linux<span style="color: #666666">-</span>CI <span style="color: #666666">:</span> UNSTABLE
OSX<span style="color: #666666">/</span>CI <span style="color: #666666">:</span> FAILURE
Prep<span style="color: #666666">...</span>
Build<span style="color: #666666">...</span> <span style="color: #666666">:</span> SUCCESS
<span style="color: #666666">==========================================</span>
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">:-)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This <a href="http://quickgit.kde.org/?p=websites%2Fbuild-kde-org.git&a=blob&h=f4e0cd7fcafe61b431ab6b6a77ef21efae27d4bc&hb=f2d024f155bed23a9e81b0175e5c7d752d6d8f14&f=documentation%2Fjob-execution.txt" style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">docu written by Ben</a> helped me figuring it out.</p></pre>
<br />
<p>- Marko</p>
<br />
<p>On January 28th, 2015, 8:09 p.m. CET, Milian Wolff wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Websites, Ben Cooksley, Marko Käning, and Scarlett Clark.</div>
<div>By Milian Wolff.</div>
<p style="color: grey;"><i>Updated Jan. 28, 2015, 8:09 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
build-kde-org
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Add more macros and ignore file templates that are invalid C++.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Add reviewboardrc file</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">REVIEW: 122294</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>.reviewboardrc <span style="color: grey">(PRE-CREATION)</span></li>
<li>config/build/kdevplatform/kf5-qt5.cfg <span style="color: grey">(0d82fce44699817baeeb0b8a6126b8da96cdcc43)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122294/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>