Review Request 122672: Updates for project dependencies

[Michael Pyne]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122672/#review76441
-----------------------------------------------------------

Ship it!


Regarding empty entries in logical-module-structure, that's also a hint to kdesrc-build that the git repository in question should not be built at all for that branch-group. However kdesrc-build defaults to assuming `master` for unknown repositories, at least at this point. I doubt this would be a problem for stable-kf5-qt5 but I did want to emphasize that the default behavior appears to be different than the CI system's defaults.

I'll note that kde-build-metadata was actually introduced for kdesrc-build so I'd like to keep it functional in that regard at least :). We're far enough along with kde-built-metadata that it might make sense to change the default for kdesrc-build, such that modules simply don't appear at all in kdesrc-build unless they are properly defined in logical-module-structure.

As far as dependencies, I'm sure you know them better than I do. I took a look and didn't see anything obviously ridiculous, so you have that going for you. ;)

- Michael Pyne


On Feb. 22, 2015, 12:19 p.m., Marko Käning wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122672/
> -----------------------------------------------------------
> 
> (Updated Feb. 22, 2015, 12:19 p.m.)
> 
> 
> Review request for KDE Websites, Albert Astals Cid, Ben Cooksley, David Faure, and Michael Pyne.
> 
> 
> Repository: kde-build-metadata
> 
> 
> Description
> -------
> 
> Hi folks,
> 
> herewith I want to suggest some changes to the CI system' build metadata:
> 
>  * remove empty stable-kf5-qt5 entries (isn't necessary for the CI due to empty default setting)
>  * update dependencies for a few newly introduced projects
> 
> Greets,
> Marko
> 
> 
> Diffs
> -----
> 
>   dependency-data-kf5-qt5 4757ca3b3c5b1930195c1fcb2f21ee6ffcd27890 
>   logical-module-structure 6bdabfee3d0f3d887d5633b9a776b7449649edc2 
> 
> Diff: https://git.reviewboard.kde.org/r/122672/diff/
> 
> 
> Testing
> -------
> 
> Successfully tested on my OSX/CI system for branch groups kf5-qt5 and stable-kf5-qt5.
> 
> 
> Thanks,
> 
> Marko Käning
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-www/attachments/20150222/c663b60b/attachment.html>