<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122672/">https://git.reviewboard.kde.org/r/122672/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Regarding empty entries in logical-module-structure, that's also a hint to kdesrc-build that the git repository in question should not be built at all for that branch-group. However kdesrc-build defaults to assuming <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">master</code> for unknown repositories, at least at this point. I doubt this would be a problem for stable-kf5-qt5 but I did want to emphasize that the default behavior appears to be different than the CI system's defaults.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'll note that kde-build-metadata was actually introduced for kdesrc-build so I'd like to keep it functional in that regard at least :). We're far enough along with kde-built-metadata that it might make sense to change the default for kdesrc-build, such that modules simply don't appear at all in kdesrc-build unless they are properly defined in logical-module-structure.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">As far as dependencies, I'm sure you know them better than I do. I took a look and didn't see anything obviously ridiculous, so you have that going for you. ;)</p></pre>
<br />
<p>- Michael Pyne</p>
<br />
<p>On February 22nd, 2015, 12:19 p.m. UTC, Marko Käning wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Websites, Albert Astals Cid, Ben Cooksley, David Faure, and Michael Pyne.</div>
<div>By Marko Käning.</div>
<p style="color: grey;"><i>Updated Feb. 22, 2015, 12:19 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-build-metadata
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Hi folks,</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">herewith I want to suggest some changes to the CI system' build metadata:</p>
<ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">remove empty stable-kf5-qt5 entries (isn't necessary for the CI due to empty default setting)</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">update dependencies for a few newly introduced projects</li>
</ul>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Greets,
Marko</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Successfully tested on my OSX/CI system for branch groups kf5-qt5 and stable-kf5-qt5.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dependency-data-kf5-qt5 <span style="color: grey">(4757ca3b3c5b1930195c1fcb2f21ee6ffcd27890)</span></li>
<li>logical-module-structure <span style="color: grey">(6bdabfee3d0f3d887d5633b9a776b7449649edc2)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122672/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>