build issue with Tellico and msvc

[Robby Stephenson]

Hi all,

Motivated by someone letting me know they had a successful build of Tellico
using craft, I've been able to make a few changes to get the master branch
compiling with MSVC locally. This is the first time I've ever compiled
anything on windows, though, having always used Linux before.

I requested a nightly build on the CI and now I'm puzzled by the fact that
my local craft build compiles without issue, but fails on the binary
factory. I'm hoping anyone on this list could give me some help or provide
pointers where I could go read to learn more.

The CI failure looks like some sort of scope/namespace issue
https://binary-factory.kde.org/job/Tellico_Nightly_win64/5/console

C:\_\9b0777e7\tellico\src\fetch\fetchrequest.cpp(32): error C2065:
'FetchKey': undeclared identifier
C:\_\9b0777e7\tellico\src\fetch\fetchrequest.cpp(32): error C2146:
syntax error: missing ')' before identifier 'key_'
C:\_\9b0777e7\tellico\src\fetch\fetchrequest.cpp(32): error C4430:
missing type specifier - int assumed. Note: C++ does not support
default-int

It may be that I've been relying on some sort of behavior from gcc or
clang that is more reliable for class name resolution that I wasn't
aware of,
but like I said, it compiles just fine for me on Windows. I can tell
that my MSVC version is slightly newer than the Ci version, but that
doesn't
seem like it's to blame. I guess my first question is how I can set up
my local build to be as similar to the CI as possible so I can test
fixes?
After that, any suggestions for what I'm doing wrong?

Thanks for any help!

Robby
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-windows/attachments/20210307/9c9a9532/attachment.htm>