Threadweaver compilation failure: Windows

[Ben Cooksley]

On Tue, Apr 18, 2017 at 6:53 PM, Kevin Funk <kfunk at kde.org> wrote:
> On Monday, 17 April 2017 22:43:56 CEST Aleix Pol wrote:
>> On Mon, Apr 17, 2017 at 6:09 AM, Ben Cooksley <bcooksley at kde.org> wrote:
>> > Hi all,
>> >
>> > If someone could take a look at the following build log that would be
>> > appreciated:
>> > https://paste.kde.org/pzyhxydjw/xxx39x/raw
>>
>> Include KDE on Windows.
>
> I don't have MSVC 2017 around to test. Threadweaver compiles fine with MSVC
> 2015.
>
> Looks like a compiler bug at any rate, the code seems fine.
>
> Possible work-around:
>
> diff --git a/examples/ThumbNailer/Model.cpp b/examples/ThumbNailer/Model.cpp
> index 1e4b111..19f233c 100644
> --- a/examples/ThumbNailer/Model.cpp
> +++ b/examples/ThumbNailer/Model.cpp
> @@ -115,7 +115,7 @@ void Model::prepareConversions(const QFileInfoList
> &filenames, const QString &ou
>      Q_ASSERT(m_images.isEmpty());
>      m_images.resize(filenames.size());
>      int counter = 0;
> -    auto initializeImage = [=, &counter] (const QFileInfo& file) {
> +    auto initializeImage = [=, &counter] (const QFileInfo& file) -> Image {
>          auto const out = QFileInfo(outputDirectory,
> file.fileName()).absoluteFilePath();
>          return Image(file.absoluteFilePath(), out, this, counter++);
>      };
>

Thanks for taking a look.

I've just tested this and unfortunately the error was the same.

>
> Cheers,
> Kevin
>

Regards,
Ben

>
>> Aleix
>
>
> --
> Kevin Funk | kfunk at kde.org | http://kfunk.org