Review Request 127187: Fix build for MSVC (2013) on Windows

Thomas Friedrichsmeier thomas.friedrichsmeier at
Mon Feb 29 13:54:46 UTC 2016

This is an automatically generated e-mail. To reply, visit:

(Updated Feb. 29, 2016, 1:54 p.m.)

Review request for KDE Frameworks, kdewin and Ivan Čukić.


Sorry, can't include a private (non-installed) header into a public header, of course. Next attempt. Main trick is again to nest the updaters inside the main class (ActivitiesModel), not friend class (ActivitiesModelPrivate). To make this possible without spelling out all different kinds of updaters, _and_ without using a private define, use a wrapper class RAIIModelUpdaters, declared inside the ActivitiesModel class declaration, but defined outside the public header.

Repository: kactivities


MSVC (2013) complains that beginResetModel(), etc. are protected. This patch allows the code to compile. It is clearly not very elegant, but both my templating- and MSVC-foo is extremely limited. Not sure, if there is a better fix.

Diffs (updated)

  src/lib/activitiesmodel.h 7258b73 
  src/lib/activitiesmodel.cpp af30f59 
  src/lib/activitiesmodel_p.h dfa861b 
  src/utils/model_updaters.h ae8e279 



Now compiles with MSVC 2013 on Windows.


Thomas Friedrichsmeier

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the Kde-windows mailing list