Review Request 127187: Fix build for MSVC (2013) on Windows

[Thomas Friedrichsmeier]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127187/
-----------------------------------------------------------

(Updated Feb. 29, 2016, 9:49 a.m.)


Review request for KDE Frameworks, kdewin and Ivan Čukić.


Changes
-------

Next attempt works by simply declaring the templated update helpers as (private) child classes of the model class (KActivities::ActivitiesModel, here), instead of its friend. Since this is private, and does not add members, I think we should be fine, and it's not _that_ ugly, in my eyes.

While this is still needed for MSVC, making this conditional on the compiler would certainly not add clarity in this approach.


Repository: kactivities


Description
-------

MSVC (2013) complains that beginResetModel(), etc. are protected. This patch allows the code to compile. It is clearly not very elegant, but both my templating- and MSVC-foo is extremely limited. Not sure, if there is a better fix.


Diffs (updated)
-----

  src/lib/activitiesmodel.h 7258b73 
  src/lib/activitiesmodel.cpp af30f59 
  src/lib/activitiesmodel_p.h dfa861b 

Diff: https://git.reviewboard.kde.org/r/127187/diff/


Testing
-------

Now compiles with MSVC 2013 on Windows.


Thanks,

Thomas Friedrichsmeier

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-windows/attachments/20160229/177775cc/attachment-0001.html>