Review Request 127709: Fix exports and avoid using sources already linked on tests.

Andrius da Costa Ribas andriusmao at gmail.com
Sat Apr 23 15:04:02 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127709/
-----------------------------------------------------------

(Updated April 23, 2016, 3:04 p.m.)


Status
------

This change has been marked as submitted.


Review request for Dolphin and kdewin.


Changes
-------

Submitted with commit c6d4cae26343b3f9f390374b70668fde428853f0 by Andrius da Costa Ribas to branch master.


Repository: dolphin


Description
-------

Rework from scratch on Review Request - 123270


Diffs
-----

  src/CMakeLists.txt 48a7c1d 
  src/kitemviews/kitemset.h 31fe1d2 
  src/tests/CMakeLists.txt 22a8b48 
  src/views/versioncontrol/kversioncontrolplugin.h 85835e0 

Diff: https://git.reviewboard.kde.org/r/127709/diff/


Testing
-------

I'm currently unable to run ctest, but this fixes all inconsistent linkage errors and warnings on Windows (MSVC 2015 64-bit).


Thanks,

Andrius da Costa Ribas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-windows/attachments/20160423/bb1eb9eb/attachment.html>


More information about the Kde-windows mailing list