Review Request 127709: Fix exports and avoid using sources already linked on tests.

Hannah von Reth vonreth at kde.org
Fri Apr 22 21:57:46 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127709/#review94774
-----------------------------------------------------------


Ship it!




Ship It!

- Hannah von Reth


On April 22, 2016, 5:28 nachm., Andrius da Costa Ribas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127709/
> -----------------------------------------------------------
> 
> (Updated April 22, 2016, 5:28 nachm.)
> 
> 
> Review request for Dolphin and kdewin.
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> Rework from scratch on Review Request - 123270
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 48a7c1d 
>   src/kitemviews/kitemset.h 31fe1d2 
>   src/tests/CMakeLists.txt 22a8b48 
>   src/views/versioncontrol/kversioncontrolplugin.h 85835e0 
> 
> Diff: https://git.reviewboard.kde.org/r/127709/diff/
> 
> 
> Testing
> -------
> 
> I'm currently unable to run ctest, but this fixes all inconsistent linkage errors and warnings on Windows (MSVC 2015 64-bit).
> 
> 
> Thanks,
> 
> Andrius da Costa Ribas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-windows/attachments/20160422/7fd9fa2f/attachment.html>


More information about the Kde-windows mailing list