Review Request 125580: Make qt-libs/poppler compile with MSVC 2015.

Albert Astals Cid aacid at kde.org
Sun Oct 11 16:49:14 UTC 2015



> On oct. 11, 2015, 3 p.m., Albert Astals Cid wrote:
> > any reason you prefer doing this here and not in upstream poppler?
> 
> Gleb Popov wrote:
>     Because emerge uses released poppler and we don't want to wait for new release with this fix incorporated. If you are upstream representative and OK with this patch, i can submit it upstream too.

I don't know who added me, but i have no interest in discussing distro patches.


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125580/#review86662
-----------------------------------------------------------


On oct. 11, 2015, 1:39 p.m., Gleb Popov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125580/
> -----------------------------------------------------------
> 
> (Updated oct. 11, 2015, 1:39 p.m.)
> 
> 
> Review request for kdewin, Albert Astals Cid and Pino Toscano.
> 
> 
> Repository: emerge
> 
> 
> Description
> -------
> 
> I've had to put #include <algorithm> everywhere, not sure if it is a right thing to do.
> 
> 
> Diffs
> -----
> 
>   portage/qt-libs/poppler/poppler-0.35.0-20151007.diff PRE-CREATION 
>   portage/qt-libs/poppler/poppler.py e26d35a 
> 
> Diff: https://git.reviewboard.kde.org/r/125580/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gleb Popov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-windows/attachments/20151011/2b88098e/attachment.html>


More information about the Kde-windows mailing list