Review Request 125580: Make qt-libs/poppler compile with MSVC 2015.

Gleb Popov 6yearold at gmail.com
Sun Oct 11 16:40:28 UTC 2015



> On Oct. 11, 2015, 6 p.m., Albert Astals Cid wrote:
> > any reason you prefer doing this here and not in upstream poppler?

Because emerge uses released poppler and we don't want to wait for new release with this fix incorporated. If you are upstream representative and OK with this patch, i can submit it upstream too.


- Gleb


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125580/#review86662
-----------------------------------------------------------


On Oct. 11, 2015, 4:39 p.m., Gleb Popov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125580/
> -----------------------------------------------------------
> 
> (Updated Oct. 11, 2015, 4:39 p.m.)
> 
> 
> Review request for kdewin, Albert Astals Cid and Pino Toscano.
> 
> 
> Repository: emerge
> 
> 
> Description
> -------
> 
> I've had to put #include <algorithm> everywhere, not sure if it is a right thing to do.
> 
> 
> Diffs
> -----
> 
>   portage/qt-libs/poppler/poppler-0.35.0-20151007.diff PRE-CREATION 
>   portage/qt-libs/poppler/poppler.py e26d35a 
> 
> Diff: https://git.reviewboard.kde.org/r/125580/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gleb Popov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-windows/attachments/20151011/5e0b48d9/attachment-0001.html>


More information about the Kde-windows mailing list