Review Request 124818: Fix update-mime-database crash.
Gleb Popov
6yearold at gmail.com
Sun Aug 23 16:45:38 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124818/
-----------------------------------------------------------
(Updated Aug. 23, 2015, 4:45 p.m.)
Status
------
This change has been marked as submitted.
Review request for kdewin.
Changes
-------
Submitted with commit cfd6e0b1c7c5a57e30fa75442c45d889a5a4e295 by Gleb Popov to branch master.
Repository: emerge
Description
-------
VS was picking wrong function types for opendir/readdir because there was no prototypes for them in dirent.h, which lead to crash.
The second crash was due to writing 8-byte intptr_t value returned by _findfirst() into a 4-byte long variable.
No idea how it was working before.
Diffs
-----
portage/win32libs/shared-mime-info/dirent.h b98296a
portage/win32libs/shared-mime-info/dirent.c 2ca945a
Diff: https://git.reviewboard.kde.org/r/124818/diff/
Testing
-------
Running `update-mime-database KDevelop/share/mime` does not crash now.
Thanks,
Gleb Popov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-windows/attachments/20150823/220570da/attachment.html>
More information about the Kde-windows
mailing list