Review Request 115110: Modify vc-based macros to allow passing flags.

[Andrius da Costa Ribas]

> On Out. 15, 2014, 4:31 p.m., Boudewijn Rempt wrote:
> > I'm sorry for the late reply, this just slipped past me somehow. I guess it isn't needed for my own builds... Is it still necessary for you, or should we discard this patch?
> 
> Andrius da Costa Ribas wrote:
>     It's quite a while since I've built last time ... Only MinGW can't build without this, iirc.

I don't have a MinGW setup anymore (and don't intend to any soon), may I discard this?


- Andrius da Costa


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115110/#review68470
-----------------------------------------------------------


On Jan. 19, 2014, 3:42 a.m., Andrius da Costa Ribas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115110/
> -----------------------------------------------------------
> 
> (Updated Jan. 19, 2014, 3:42 a.m.)
> 
> 
> Review request for Calligra and kdewin.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> This was needed because the generated object files are not generated as part of the shared lib target, having not defined the -DMAKE_XXXX_LIB that is automatically defined by CMake otherwise.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 62f8e79 
>   krita/image/CMakeLists.txt eefaf61 
>   libs/pigment/CMakeLists.txt 0073377 
> 
> Diff: https://git.reviewboard.kde.org/r/115110/diff/
> 
> 
> Testing
> -------
> 
> Tested building on both MSVC and MinGW
> 
> 
> Thanks,
> 
> Andrius da Costa Ribas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-windows/attachments/20150404/db74d0ff/attachment.html>