Review Request 114984: Fix build on MinGW with newer Windows SDK's strsafe.h
Andrius da Costa Ribas
andriusmao at gmail.com
Sat Apr 4 18:14:01 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114984/
-----------------------------------------------------------
(Updated Abril 4, 2015, 6:14 p.m.)
Status
------
This change has been discarded.
Review request for KDE Runtime and kdewin.
Repository: kde-runtime
Description
-------
When building with MinGW new conflicts appeared when including strsafe before Qt headers (specially QString included from QBuffer). Also a new weird compiling error telling "'lstrcpy_instead_use_stringcbcopy_or_stringcchcopy' undeclared identifier" appeared, so I replaced lstrcpy with the equivalent use of StringCchCopy (http://msdn.microsoft.com/en-us/library/windows/desktop/ms647527(v=vs.85).aspx).
Diffs
-----
kioslave/thumbnail/icoutils_win.cpp e223aa1
Diff: https://git.reviewboard.kde.org/r/114984/diff/
Testing
-------
Tested using MinGW, thumbnails still work fine. No errors when building with MSVC either.
Thanks,
Andrius da Costa Ribas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-windows/attachments/20150404/71397b3f/attachment.html>
More information about the Kde-windows
mailing list