Review Request 117828: prevent ex/import in exported classes used in tests

Patrick Spendrin ps_ml at gmx.de
Mon Apr 28 14:43:17 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117828/
-----------------------------------------------------------

(Updated April 28, 2014, 2:43 p.m.)


Status
------

This change has been marked as submitted.


Review request for Baloo and kdewin.


Repository: baloo


Description
-------

If using class definitions of exported classes in tests, the export/import mechanism isn't needed. To prevent linker errors, set the EXPORT macro to empty.


Diffs
-----

  src/file/autotest/CMakeLists.txt a54736e 
  src/file/autotest/fileindexingjob/CMakeLists.txt 811ed30 
  src/file/lib/autotests/CMakeLists.txt 95a0916 
  src/file/search/autotest/CMakeLists.txt eb058d2 
  src/file/tests/CMakeLists.txt 102c981 

Diff: https://git.reviewboard.kde.org/r/117828/diff/


Testing
-------

windows msvc 2010


Thanks,

Patrick Spendrin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-windows/attachments/20140428/3fa2d79a/attachment.html>


More information about the Kde-windows mailing list