Review Request 117828: prevent ex/import in exported classes used in tests

Vishesh Handa me at vhanda.in
Mon Apr 28 12:43:55 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117828/#review56739
-----------------------------------------------------------

Ship it!


I don't get why MSVC doesn't just ignore it, but sure.

- Vishesh Handa


On April 28, 2014, 9:50 a.m., Patrick Spendrin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117828/
> -----------------------------------------------------------
> 
> (Updated April 28, 2014, 9:50 a.m.)
> 
> 
> Review request for Baloo and kdewin.
> 
> 
> Repository: baloo
> 
> 
> Description
> -------
> 
> If using class definitions of exported classes in tests, the export/import mechanism isn't needed. To prevent linker errors, set the EXPORT macro to empty.
> 
> 
> Diffs
> -----
> 
>   src/file/autotest/CMakeLists.txt a54736e 
>   src/file/autotest/fileindexingjob/CMakeLists.txt 811ed30 
>   src/file/lib/autotests/CMakeLists.txt 95a0916 
>   src/file/search/autotest/CMakeLists.txt eb058d2 
>   src/file/tests/CMakeLists.txt 102c981 
> 
> Diff: https://git.reviewboard.kde.org/r/117828/diff/
> 
> 
> Testing
> -------
> 
> windows msvc 2010
> 
> 
> Thanks,
> 
> Patrick Spendrin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-windows/attachments/20140428/851ba353/attachment.html>


More information about the Kde-windows mailing list