errors in applying patches to qt 4.8.5 (yet the build continues)

[Nico Kruber]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

It seems that several patches are applied to 4.8.5 but fail - yet the
build continues.

If a patch was set in the portage file and does not apply, shouldn't
the build fail immediately?

We should of course also re-evaluate the patches and see what is
really needed and what is not any more (e.g. if included upstream).


here's the start of my log from building qt:
(btw: you'll also find a typo at the last line: "Overiding" needs an
extra "r" -> "Overriding" - which reminds me that I should maybe setup
an IDE project to quickly find the occurrences, if someone else does,
please fix)
- --------------------------------------------------
creating:
D:\kderoot\build\libs\qt-4.8.2.20120321\work\msvc2010-RelWithDebInfo-4.8.5
entering:
D:\kderoot\build\libs\qt-4.8.2.20120321\work\msvc2010-RelWithDebInfo-4.8.5
cleaning
D:\kderoot\build\libs\qt-4.8.2.20120321\work\msvc2010-RelWithDebInfo-4.8.5
D:\kderoot\emerge\portage\libs\qt\patches/4.7/out-of-source-build.patch:27:
trailing whitespace.
    my $cnt_ofs = 0;
D:\kderoot\emerge\portage\libs\qt\patches/4.7/out-of-source-build.patch:28:
trailing whitespace.
    if($match_dir =~ /^[a-zA-Z]:$/) {
D:\kderoot\emerge\portage\libs\qt\patches/4.7/out-of-source-build.patch:29:
trailing whitespace.
      $cnt_ofs = 1;
D:\kderoot\emerge\portage\libs\qt\patches/4.7/out-of-source-build.patch:30:
trailing whitespace.
    }
D:\kderoot\emerge\portage\libs\qt\patches/4.7/out-of-source-build.patch:34:
trailing whitespace.
        my $count = ($after =~ tr,/,,) - $cnt_ofs;
warning: bin/syncqt has type 100644, expected 100755
error: patch failed: bin/syncqt:366
error: bin/syncqt: patch does not apply
error: patch failed: src/tools/moc/main.cpp:94
error: src/tools/moc/main.cpp: patch does not apply
D:\kderoot\emerge\portage\libs\qt\patches/4.8/add-pdbs-on-msvc.diff:8:
trailing whitespace.
#!isEmpty(QT_BREAKPAD_ROOT_PATH): \   # quick test first whether
requested ...
D:\kderoot\emerge\portage\libs\qt\patches/4.8/add-pdbs-on-msvc.diff:13:
trailing
whitespace.
#        system($$QT_BREAKPAD_ROOT_PATH/qtbreakpadsymbols
- --breakpad-exists) {    # do we really have it?
D:\kderoot\emerge\portage\libs\qt\patches/4.8/add-pdbs-on-msvc.diff:14:
trailing
whitespace.
#    CONFIG += breakpad
D:\kderoot\emerge\portage\libs\qt\patches/4.8/add-pdbs-on-msvc.diff:20:
trailing
whitespace.
#}
D:\kderoot\emerge\portage\libs\qt\patches/4.8/add-pdbs-on-msvc.diff:29:
trailing
whitespace.
#breakpad {
error: patch failed: mkspecs/features/default_post.prf:1
error: mkspecs/features/default_post.prf: patch does not apply
D:\kderoot\emerge\portage\libs\qt\patches/4.8/fix-debug-webkit-linkage-QTBUG-20556.patch:7:
trailing whitespace.
QMAKE_LFLAGS_LTCG =
D:\kderoot\emerge\portage\libs\qt\patches/4.8/fix-debug-webkit-linkage-QTBUG-20556.patch:8:
trailing whitespace.
QMAKE_CXXFLAGS_LTCG =
D:\kderoot\emerge\portage\libs\qt\patches/4.8/fix-debug-webkit-linkage-QTBUG-20556.patch:9:
trailing whitespace.
QMAKE_CFLAGS_LTCG =
D:\kderoot\emerge\portage\libs\qt\patches/4.8/fix-debug-webkit-linkage-QTBUG-20556.patch:10:
trailing whitespace.

error: patch failed: src\3rdparty\webkit\Source\WebCore\WebCore.pro:18
error: src\3rdparty\webkit\Source\WebCore\WebCore.pro: patch does not
apply
D:\kderoot\emerge\portage\libs\qt\patches/4.8.1/Use-windows-path-for-pkgconfig-mkdir_p_asstring.patch:20:
trailing whitespace.
                    ret += mkdir_p_asstring(fileFixify(dst_pc_dir,
FileFixifyAbsolute), true);
error: patch failed: qmake/generators/win32/winmakefile.cpp:850
error: qmake/generators/win32/winmakefile.cpp: patch does not apply
D:\kderoot\emerge\portage\libs\qt\patches/4.8/moc-boost-fix-bug-22829.diff:9:
trailing whitespace.
    pp.macros["BOOST_TT_HAS_OPERATOR_HPP_INCLUDED"]; // QTBUG-22829
error: patch failed: src/tools/moc/main.cpp:187
error: src/tools/moc/main.cpp: patch does not apply
D:\kderoot\emerge\portage\libs\qt\patches/4.8.4/fix-defined-defined-and-do-not-include-inttypes-for-intel-compiler.patch:10:
trailing whitespace.
#if (defined WTF_USE_JSVALUE32_64 && WTF_USE_JSVALUE32_64)
D:\kderoot\emerge\portage\libs\qt\patches/4.8.4/fix-defined-defined-and-do-not-include-inttypes-for-intel-compiler.patch:19:
trailing whitespace.
#if (defined WTF_USE_JSVALUE32_64 && WTF_USE_JSVALUE32_64)
D:\kderoot\emerge\portage\libs\qt\patches/4.8.4/fix-defined-defined-and-do-not-include-inttypes-for-intel-compiler.patch:28:
trailing whitespace.
#if (defined WTF_USE_JSVALUE32_64 && WTF_USE_JSVALUE32_64)
D:\kderoot\emerge\portage\libs\qt\patches/4.8.4/fix-defined-defined-and-do-not-include-inttypes-for-intel-compiler.patch:41:
trailing whitespace.
#if (defined WTF_OS_DARWIN && WTF_OS_DARWIN)
D:\kderoot\emerge\portage\libs\qt\patches/4.8.4/fix-defined-defined-and-do-not-include-inttypes-for-intel-compiler.patch:50:
trailing whitespace.
#if (defined WTF_OS_DARWIN && WTF_OS_DARWIN)
error: patch failed:
src/3rdparty/javascriptcore/JavaScriptCore/jit/ExecutableAllocatorFixedVMPool.cpp:37
error:
src/3rdparty/javascriptcore/JavaScriptCore/jit/ExecutableAllocatorFixedVMPool.cpp:
patch does not apply
D:\kderoot\emerge\portage\libs\qt\patches/4.8.4/fix-Q_CORE_EXPORT_INLINE-for-intel-compiler.patch:11:
trailing whitespace.
// Compilers like MinGW and Intel complain that the import attribute
is ignored.
D:\kderoot\emerge\portage\libs\qt\patches/4.8.4/fix-Q_CORE_EXPORT_INLINE-for-intel-compiler.patch:12:
trailing whitespace.
#if defined(Q_CC_MINGW) || (defined(Q_CC_INTEL) && defined(Q_OS_WIN))
error: patch failed: src/corelib/global/qglobal.h:1461
error: src/corelib/global/qglobal.h: patch does not apply
emerge warning: Overiding D:\kderoot\git\qt-4.8.2\configure.exe
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (MingW32)

iEYEARECAAYFAlIhSDMACgkQIPJyS9rqnlliPwCffbV2y7MeLvD0+PRiMIi6iEKG
qWMAnRxOkL3JWJsUa44b3CBXuahkdosc
=KdUA
-----END PGP SIGNATURE-----