kde-baseapps and X11 libs

Patrick Spendrin ps_ml at gmx.de
Tue Apr 23 22:05:53 UTC 2013


Am 23.04.2013 23:27, schrieb Michael Drüing:
> Hi,
> 
>  
> 
> this commit
> 
> http://quickgit.kde.org/?p=kde-baseapps.git&a=commitdiff&h=81f7f6ac236dc4bc641a58c8ee4187fba106d267
> 
> broke compilation for Win32. I think it should be safe to put the
> find_package into an if(Q_WS_X11) block but I’m not sure. I couldn’t
> find any direct X11 calls outside any #ifdef Q_WS_X11 block, but I
> didn’t want to make this change without getting some confirmation from
> someone who knows the code better than I do (ATM it won’t compile on
> MSVC even after removing the find_package because of some other problems
> I’m still investigating)

Just go ahead. Make sure you use if(Q_WS_X11) and not if(NOT WIN32).

> 
>  
> 
> thanks
> 
> -Michael
> 

regards & thanks for spotting this,
Patrick



More information about the Kde-windows mailing list