Review Request: KF5 - Q_OS_* not defined

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105868/#review19247
-----------------------------------------------------------

Ship it!


Please commit, the current stuff (Q_OS in CMakeLists.txt) is just wrong :)

- David Faure


On Aug. 5, 2012, 10:28 p.m., Andrius da Costa Ribas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105868/
> -----------------------------------------------------------
> 
> (Updated Aug. 5, 2012, 10:28 p.m.)
> 
> 
> Review request for KDE Frameworks and kdewin.
> 
> 
> Description
> -------
> 
> Q_OS_WIN & Q_OS_MAC not defined at that point, replacing with WIN32 and APPLE.
> 
> 
> Diffs
> -----
> 
>   kde3support/KDE3SupportMacros.cmake a4f44e2 
>   kdecore/CMakeLists.txt e5cbd19 
>   kded/CMakeLists.txt fb204e8 
>   kdeui/CMakeLists.txt 7849b52 
>   kdeui/KDEUIMacros.cmake d5c20d9 
>   kinit/CMakeLists.txt 3c283a6 
>   tier1/kidletime/src/CMakeLists.txt 973d623 
>   tier1/kwindowsystem/src/CMakeLists.txt 96cb3dd 
> 
> Diff: http://git.reviewboard.kde.org/r/105868/diff/
> 
> 
> Testing
> -------
> 
> Got undefined references before the fix.
> 
> 
> Thanks,
> 
> Andrius da Costa Ribas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-windows/attachments/20120920/00608662/attachment.html>