<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105868/">http://git.reviewboard.kde.org/r/105868/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please commit, the current stuff (Q_OS in CMakeLists.txt) is just wrong :)</pre>
<br />
<p>- David</p>
<br />
<p>On August 5th, 2012, 10:28 p.m., Andrius da Costa Ribas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and kdewin.</div>
<div>By Andrius da Costa Ribas.</div>
<p style="color: grey;"><i>Updated Aug. 5, 2012, 10:28 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Q_OS_WIN & Q_OS_MAC not defined at that point, replacing with WIN32 and APPLE.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Got undefined references before the fix.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kde3support/KDE3SupportMacros.cmake <span style="color: grey">(a4f44e2)</span></li>
<li>kdecore/CMakeLists.txt <span style="color: grey">(e5cbd19)</span></li>
<li>kded/CMakeLists.txt <span style="color: grey">(fb204e8)</span></li>
<li>kdeui/CMakeLists.txt <span style="color: grey">(7849b52)</span></li>
<li>kdeui/KDEUIMacros.cmake <span style="color: grey">(d5c20d9)</span></li>
<li>kinit/CMakeLists.txt <span style="color: grey">(3c283a6)</span></li>
<li>tier1/kidletime/src/CMakeLists.txt <span style="color: grey">(973d623)</span></li>
<li>tier1/kwindowsystem/src/CMakeLists.txt <span style="color: grey">(96cb3dd)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105868/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>