[Bug 292062] KDirSelectDialog::selectDirectory usage results in an infinite loop

[Andre Heinecke]

https://bugs.kde.org/show_bug.cgi?id=292062





--- Comment #4 from Andre Heinecke <aheinecke intevation de>  2012-01-23 16:24:03 ---
This bug is fun.

According to the documentation:
http://api.kde.org/4.x-api/kdelibs-apidocs/kdecore/html/classKUrl.html#a5a89a0a2d5af55d75e808cc029a24172

"The algorithm tries to go up on the right-most URL. If that is not possible it
strips the right most URL. It continues stripping URLs."

So you would expect to end up with file:/// on Windows too (everything is
stripped in the end)

But in the implementation:
http://api.kde.org/4.x-api/kdelibs-apidocs/kdecore/html/kurl_8cpp_source.html#l01475
it basically does cd ..
(So you would expect to end up with file://// on Linux and file:///C/ on
Windows)

I would say the correct fix here would be to end up with file:/// on windows
and linux because ultimately when you go upDir you want to end up on something
like a drive overview and not on the current drive. Which would also be
according to the documentation that it strips the rightmost url until no more
url is left.

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.