kdesupport/emerge/bin/BuildSystem

[Ralf Habacker]

Am 09.03.2011 13:04, schrieb Wolfgang Rohdewald:
>
> On Freitag 04 März 2011, Ralf Habacker wrote:
>
> > SVN commit 1223691 by habacker:
>
> >
>
> > - define noop methods
>
> > +
>
> > + def configure(self):
>
> > + return True
>
> > +
>
> > + def make(self):
>
> > + return True
>
> > +
>
> > + def install(self):
>
> > + return True
>
>
> those were defined as abstract before I removed them
>
> with commit r1221902 - so if they ever were called,
>
> emerge would die. IOW they are never called.
>
>
> Why are those methods needed?
>
> r1221902 | wrohdewald | 2011-02-21 01:13:29 +0100 (Mo, 21. Feb 2011) | 
> 11 Zeilen
>
>
> BuildSystemBase: remove abstract methods
>
>
> those methods like configure() are redefined in derived
>
> classes with conflicting signatures like configure()
>
> in BinaryBuildSystem and QMakeBuildSystem(). This makes
>
> it pointless to define a common ancestor.
>
>
> By removing those methods, emerge (not pylint as the
>
> commit says) will still raise an exception if a derived
>
> class does not implement them, and pylint is happier.
>
I'm cleaning this up.  The QMakeBuildSystem is already solved and the 
other will follow :-)

Ralf

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-windows/attachments/20110324/3008a121/attachment.html