emerge/bin/Source/GitSource: git createPatch is wrong for python sources

Wolfgang Rohdewald wolfgang at rohdewald.de
Tue Mar 15 12:34:05 CET 2011


because leading space has a meaning, but those differences
will not be in the patch file.

of course such a patch should really be committed upstream
so maybe there is no imminent need for fixing this - but
I think if a patch is applied or created involving .py
files, a big warning should be shown to the user.

That is so since this commit:

Author: aheinecke <aheinecke at 283d02a7-25f6-0310-bc7c-
ecb5cbfe19da>
Date:   Thu Sep 16 13:50:00 2010 +0000

    Ignore whitespaces when creating and applying git patches.
        This has often be the cause for bad patches in emerge 
which
        were not applied. I also personaly doubt that it is 
useful
        to make style changes (for whitespace) in emerge patches.

-- 
Wolfgang
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-windows/attachments/20110315/8dd1ba00/attachment.htm 


More information about the Kde-windows mailing list