Review Request: Creation of manifest files: close them after writing and code deduplication

[Wolfgang Rohdewald]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6424/
-----------------------------------------------------------

(Updated Jan. 30, 2011, 1:26 p.m.)


Review request for kde-windows.


Changes
-------

sorry, fixed now. I only tested with "emerge subversion" which only generates binaries


Summary
-------

This eliminates code duplication.
And it makes sure that the files are closed after being written. Until now, they were not closed at all.
Writing a file and not closing it is not recommended. It is implementation dependent if and when the
data will actually be written.


Diffs (updated)
-----

  /trunk/kdesupport/emerge/bin/utils.py 1217952 

Diff: http://svn.reviewboard.kde.org/r/6424/diff


Testing
-------


Thanks,

Wolfgang

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-windows/attachments/20110130/f0c304ae/attachment.htm