Review Request: Creation of manifest files: close them after writing and code deduplication

[ralf.habacker at freenet.de]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6424/#review9764
-----------------------------------------------------------


the following lines are not initegrated into the patch and will result into broken .ver files 
    if len(binList) > 0:
 	binversion.write( "%s %s Binaries\n%s/%s:%s:unknown" % ( package, version, category, package, version ) )
    if len(libList) > 0:
        libversion.write( "%s %s developer files\n%s/%s:%s:unknown" % ( package, version, category, package, version ) )
    if len(docList) > 0:
        docversion.write( "%s %s Documentation\n%s/%s:%s:unknown" % ( package, version, category, package, version ) )

Regards 
Ralf 


- ralf.habacker


On Jan. 30, 2011, 11:14 a.m., Wolfgang Rohdewald wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6424/
> -----------------------------------------------------------
> 
> (Updated Jan. 30, 2011, 11:14 a.m.)
> 
> 
> Review request for kde-windows.
> 
> 
> Summary
> -------
> 
> This eliminates code duplication.
> And it makes sure that the files are closed after being written. Until now, they were not closed at all.
> Writing a file and not closing it is not recommended. It is implementation dependent if and when the
> data will actually be written.
> 
> 
> Diffs
> -----
> 
>   /trunk/kdesupport/emerge/bin/utils.py 1217952 
> 
> Diff: http://svn.reviewboard.kde.org/r/6424/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Wolfgang
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-windows/attachments/20110130/a422d9c9/attachment.htm