Review Request: simplify verbosity handling

[Ralf Habacker]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6340/#review9650
-----------------------------------------------------------

Ship it!


looks good to me. 


- Ralf


On Jan. 16, 2011, 1:10 p.m., Wolfgang Rohdewald wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6340/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2011, 1:10 p.m.)
> 
> 
> Review request for kde-windows.
> 
> 
> Summary
> -------
> 
>     Simplify verbosity handling code:
>     - do not use global variables anymore (pylint)
>     - introduce a class Verbosity instead
>     - alyways keep shell variable EMERGE_VERBOSE in sync
>     - new context class TemporaryVerbosity. Use it in dumpDependencies
> 
> 
> Diffs
> -----
> 
>   /trunk/kdesupport/emerge/bin/dependencies.py 1214807 
>   /trunk/kdesupport/emerge/bin/emerge.py 1214807 
>   /trunk/kdesupport/emerge/bin/tools.py 1214807 
>   /trunk/kdesupport/emerge/bin/utils.py 1214807 
> 
> Diff: http://svn.reviewboard.kde.org/r/6340/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Wolfgang
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-windows/attachments/20110118/5efcb7eb/attachment.htm