emerge python code

[Wolfgang Rohdewald]

On Sonntag 09 Januar 2011, Patrick Spendrin wrote:
> Hm, you could start that, but the question is how much work
> overhead that is, since people might not be that interested.
> Wrt. docstrings, we can definitely try and improve that
> situation, that shouldn't hurt at all.

meanwhile I have a few first patches in my local git repository,
see below. They are not yet ready, I need to test them. And
I only want to really commit patches when the amount of
pylint messages is much more reduced.

just to give you an idea of what I am doing. 

what do I do when the patchset is ready? Directly commit?
Put into the reviewboard?

and I have a question: Some functions use argument names
like dir or type. Those a predefined built-ins. It is of
course allowed to redefine them locally but there should
be a good reason for doing this.

but I cannot rename arguments unless I can also rename
them in all callers of this function. So: Is the code
in emerge/bin only referenced here and in portage or
is there any other external use outside of kdesupport?

Author: Wolfgang Rohdewald <wolfgang at rohdewald.de>
Date:   Sun Jan 9 05:33:38 2011 +0100

    replace obsolescent <> by !=

Author: Wolfgang Rohdewald <wolfgang at rohdewald.de>
Date:   Sun Jan 9 05:47:52 2011 +0100

    Indentation should always be 4 spaces. This was mostly so but 
not
    always. This is only a formatting change.

Author: Wolfgang Rohdewald <wolfgang at rohdewald.de>
Date:   Sun Jan 9 05:51:58 2011 +0100

    Never mix tabs and spaces for indenting within the same file

Author: Wolfgang Rohdewald <wolfgang at rohdewald.de>
Date:   Sun Jan 9 05:55:08 2011 +0100

    portage_versions.py used tabs for indentation, change to 4 
spaces

Author: Wolfgang Rohdewald <wolfgang at rohdewald.de>
Date:   Sun Jan 9 06:06:03 2011 +0100

    remove unneeded semicolon after last statement in line

Author: Wolfgang Rohdewald <wolfgang at rohdewald.de>
Date:   Sun Jan 9 06:33:10 2011 +0100

    comma: no space before, always one space after

Author: Wolfgang Rohdewald <wolfgang at rohdewald.de>
Date:   Sun Jan 9 06:38:52 2011 +0100

    operators should always be followed by a space

Author: Wolfgang Rohdewald <wolfgang at rohdewald.de>
Date:   Sun Jan 9 10:49:45 2011 +0100

    we do not want more than one statement per line for clarity.
    This patch contains only whitespace changes.

Author: Wolfgang Rohdewald <wolfgang at rohdewald.de>
Date:   Sun Jan 9 10:56:07 2011 +0100

    fix more places with more than one statement per line.
    Those fixes actually change the code.

Author: Wolfgang Rohdewald <wolfgang at rohdewald.de>
Date:   Sun Jan 9 11:19:52 2011 +0100

    fix pylint warnings about usage of possibly undefined loop 
variables.
    In emerge.py, the argument scanner is simplified as a side 
result

Author: Wolfgang Rohdewald <wolfgang at rohdewald.de>
Date:   Sun Jan 9 12:17:32 2011 +0100

    since we now require python2.7, remove optparse code. Always 
use
    argparse code.

-- 
Wolfgang
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-windows/attachments/20110109/af267a9c/attachment.htm