Review Request: Simplify SourceBase.applyPatches

[Wolfgang Rohdewald]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6527/
-----------------------------------------------------------

(Updated Feb. 27, 2011, 10:49 p.m.)


Review request for kde-windows.


Changes
-------

I forgot to change debug() in utils.applyPatch(): change verbosity from 2 to 0
this adds debug output for some packages calling utils.applyPatch() directly.

SourceBase.applyPatch()/applyPatches() does not need to warn about failed 
patches because utils.applyPatch() already does

actually I think utils.applyPatch() should be integrated into SourceBase.applyPatch()


Summary
-------

simplifies the source code. Make no exception for being called with only one patch.
Remove warning for failed patch from applyPatches, applyPatch warns.
log a warning if applyPatch is called without a patch file name


Diffs (updated)
-----

  /trunk/kdesupport/emerge/bin/Source/SourceBase.py 1222425 
  /trunk/kdesupport/emerge/bin/utils.py 1222512 

Diff: http://svn.reviewboard.kde.org/r/6527/diff


Testing
-------


Thanks,

Wolfgang

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-windows/attachments/20110227/21e321f2/attachment.htm