Review Request: utils / manifests: Cleanup, fixes

[Wolfgang Rohdewald]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6524/
-----------------------------------------------------------

Review request for kde-windows.


Summary
-------

It happened to me that a manifest file did not exist when emerge tried to open it and emerge died, so I looked closer at this code.

After some refactoring, this is fixed. Also:

- removing code duplication: less source code
- more complete docstrings
- if a manifest file appears twice in *.mft, emerge tried to delete it twice, so it
  logged a warning about a missing file. Fixed.
- in the same situation, if one of the entries had a hash and the other not, the hash
  was not checked before deleting. Now it is.

those 2 problems happen with dev-util/uactools, unmerging this will now result in a
warning that uactools-20101219-bin.mft has a wrong hash (which it has).


Diffs
-----

  /trunk/kdesupport/emerge/bin/utils.py 1221559 

Diff: http://svn.reviewboard.kde.org/r/6524/diff


Testing
-------


Thanks,

Wolfgang

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-windows/attachments/20110219/03cc7c91/attachment.htm