<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6524/">http://svn.reviewboard.kde.org/r/6524/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kde-windows.</div>
<div>By Wolfgang Rohdewald.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It happened to me that a manifest file did not exist when emerge tried to open it and emerge died, so I looked closer at this code.
After some refactoring, this is fixed. Also:
- removing code duplication: less source code
- more complete docstrings
- if a manifest file appears twice in *.mft, emerge tried to delete it twice, so it
logged a warning about a missing file. Fixed.
- in the same situation, if one of the entries had a hash and the other not, the hash
was not checked before deleting. Now it is.
those 2 problems happen with dev-util/uactools, unmerging this will now result in a
warning that uactools-20101219-bin.mft has a wrong hash (which it has).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/kdesupport/emerge/bin/utils.py <span style="color: grey">(1221559)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6524/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>