Review Request: utils.system(): simplify and fix a potential problem

[Wolfgang Rohdewald]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6514/
-----------------------------------------------------------

Review request for kde-windows.


Summary
-------

make utils.systemWithoutShell() safer to use, just like utils.system()
avoid code duplication between them

remove *args from parameter list, this is never used and Popen would
not accept those args anyway

simplify definition of utils.system()

close file test.outlog when done


Diffs
-----

  /trunk/kdesupport/emerge/bin/EmergeBase.py 1221544 
  /trunk/kdesupport/emerge/bin/Source/HgSource.py 1221544 
  /trunk/kdesupport/emerge/bin/Source/SvnSource.py 1221544 
  /trunk/kdesupport/emerge/bin/base.py 1221544 
  /trunk/kdesupport/emerge/bin/shells.py 1221544 
  /trunk/kdesupport/emerge/bin/utils.py 1221544 
  /trunk/kdesupport/emerge/portage/dev-util/git/git-1.7.0.2-1.py 1221544 

Diff: http://svn.reviewboard.kde.org/r/6514/diff


Testing
-------

compiles kdelibs


Thanks,

Wolfgang

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-windows/attachments/20110218/5bd6274e/attachment.html