<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6514/">http://svn.reviewboard.kde.org/r/6514/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kde-windows.</div>
<div>By Wolfgang Rohdewald.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">make utils.systemWithoutShell() safer to use, just like utils.system()
avoid code duplication between them
remove *args from parameter list, this is never used and Popen would
not accept those args anyway
simplify definition of utils.system()
close file test.outlog when done</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">compiles kdelibs</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/kdesupport/emerge/bin/EmergeBase.py <span style="color: grey">(1221544)</span></li>
<li>/trunk/kdesupport/emerge/bin/Source/HgSource.py <span style="color: grey">(1221544)</span></li>
<li>/trunk/kdesupport/emerge/bin/Source/SvnSource.py <span style="color: grey">(1221544)</span></li>
<li>/trunk/kdesupport/emerge/bin/base.py <span style="color: grey">(1221544)</span></li>
<li>/trunk/kdesupport/emerge/bin/shells.py <span style="color: grey">(1221544)</span></li>
<li>/trunk/kdesupport/emerge/bin/utils.py <span style="color: grey">(1221544)</span></li>
<li>/trunk/kdesupport/emerge/portage/dev-util/git/git-1.7.0.2-1.py <span style="color: grey">(1221544)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6514/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>