Review Request: Debug packages support in kdewin-installer

[Ralf Habacker]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4899/#review6791
-----------------------------------------------------------


Looks good so far. I committed it with a spelling fix 

+        if ( installedPackage->isInstalled ( Package::DBG ) )
+            list += tr ( "---- SRC package ----" ) + "\n" + engine->database()->getPackageFiles ( installedPackage->name(),Package::DBG ).join ( "\n" ) + "\n";
         if ( list.isEmpty() )

should be 

+        if ( installedPackage->isInstalled ( Package::DBG ) )
+            list += tr ( "---- DBG package ----" ) + "\n" + engine->database()->getPackageFiles ( installedPackage->name(),Package::DBG ).join ( "\n" ) + "\n";
         if ( list.isEmpty() )


- Ralf


On 2010-08-04 10:01:33, Ilie Halip wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4899/
> -----------------------------------------------------------
> 
> (Updated 2010-08-04 10:01:33)
> 
> 
> Review request for kde-windows.
> 
> 
> Summary
> -------
> 
> This patch adds a new package type: DBG, and a new column in the packages list view, making it possible to install debug packages on Windows. This does not address the server-side build scripts.
> 
> 
> Diffs
> -----
> 
>   /trunk/kdesupport/kdewin-installer/console/installerengineconsole.cpp 1159076 
>   /trunk/kdesupport/kdewin-installer/gui/installerenginegui.cpp 1159076 
>   /trunk/kdesupport/kdewin-installer/gui/packageselectorpage.cpp 1159076 
>   /trunk/kdesupport/kdewin-installer/shared/globalconfig.cpp 1159076 
>   /trunk/kdesupport/kdewin-installer/shared/package.h 1159076 
>   /trunk/kdesupport/kdewin-installer/shared/package.cpp 1159076 
>   /trunk/kdesupport/kdewin-installer/shared/packagelist.cpp 1159076 
>   /trunk/kdesupport/kdewin-installer/shared/packagestates.h 1159076 
>   /trunk/kdesupport/kdewin-installer/shared/packagestates.cpp 1159076 
> 
> Diff: http://reviewboard.kde.org/r/4899/diff
> 
> 
> Testing
> -------
> 
> - locally tested kdewin-installer
> - made sure it works with the current mirrors
> 
> 
> Thanks,
> 
> Ilie
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-windows/attachments/20100804/334c430a/attachment.htm