<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/4899/">http://reviewboard.kde.org/r/4899/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good so far. I committed it with a spelling fix
+ if ( installedPackage->isInstalled ( Package::DBG ) )
+ list += tr ( "---- SRC package ----" ) + "\n" + engine->database()->getPackageFiles ( installedPackage->name(),Package::DBG ).join ( "\n" ) + "\n";
if ( list.isEmpty() )
should be
+ if ( installedPackage->isInstalled ( Package::DBG ) )
+ list += tr ( "---- DBG package ----" ) + "\n" + engine->database()->getPackageFiles ( installedPackage->name(),Package::DBG ).join ( "\n" ) + "\n";
if ( list.isEmpty() )
</pre>
<br />
<p>- Ralf</p>
<br />
<p>On August 4th, 2010, 10:01 a.m., Ilie Halip wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kde-windows.</div>
<div>By Ilie Halip.</div>
<p style="color: grey;"><i>Updated 2010-08-04 10:01:33</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch adds a new package type: DBG, and a new column in the packages list view, making it possible to install debug packages on Windows. This does not address the server-side build scripts.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">- locally tested kdewin-installer
- made sure it works with the current mirrors</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/kdesupport/kdewin-installer/console/installerengineconsole.cpp <span style="color: grey">(1159076)</span></li>
<li>/trunk/kdesupport/kdewin-installer/gui/installerenginegui.cpp <span style="color: grey">(1159076)</span></li>
<li>/trunk/kdesupport/kdewin-installer/gui/packageselectorpage.cpp <span style="color: grey">(1159076)</span></li>
<li>/trunk/kdesupport/kdewin-installer/shared/globalconfig.cpp <span style="color: grey">(1159076)</span></li>
<li>/trunk/kdesupport/kdewin-installer/shared/package.h <span style="color: grey">(1159076)</span></li>
<li>/trunk/kdesupport/kdewin-installer/shared/package.cpp <span style="color: grey">(1159076)</span></li>
<li>/trunk/kdesupport/kdewin-installer/shared/packagelist.cpp <span style="color: grey">(1159076)</span></li>
<li>/trunk/kdesupport/kdewin-installer/shared/packagestates.h <span style="color: grey">(1159076)</span></li>
<li>/trunk/kdesupport/kdewin-installer/shared/packagestates.cpp <span style="color: grey">(1159076)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/4899/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>