KUrl test false alarm

Patrick Spendrin ps_ml at gmx.de
Wed Nov 11 20:37:56 CET 2009


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Peter Kümmel schrieb:
> Looking at some unit tests I found that a test for KUrl fails:
> 
> FAIL!  : KUrlTest::testSetFileName() Compared values are not the same
>    Actual (singleFile.path()): /bar.bin
>    Expected (QString("bar.bin")): bar.bin
> ..\..\..\..\..\..\svn\trunk\KDE\kdelibs\kdecore\tests\kurltest.cpp(634) : failure location
> 
> 
> In KUrl I found this comment:
>     //This is necessary because QUrl has the "path" part including the first slash
>     //Without this QUrl doesn't understand that this is a path, and some operations fail
>     //e.g. C:/blah needs to become /C:/blah
> 
> Therefore I assume the FAIL is a false alarm, see attached patch.
replace path() with toLocalFile() should help.
This has been introduced not so long ago I think.
> 
> Any comments?
> 
> Peter
> 
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> Kde-windows mailing list
> Kde-windows at kde.org
> https://mail.kde.org/mailman/listinfo/kde-windows

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (MingW32)

iEYEARECAAYFAkr7EpQACgkQi49rfdk/G3bybQCfejaCgAm+gvS1j7d5scSMjAPC
ESUAni7Q147IGbWXBQtDOySGWG0ojsYK
=wmmb
-----END PGP SIGNATURE-----


More information about the Kde-windows mailing list