Proposal: reenable --style for all targets

Aaron J. Seigo aseigo at
Thu Nov 13 01:04:31 CET 2008

On Wednesday 12 November 2008, you wrote:
> So I am still proposing just removing the #ifdef Q_WS_X11...

looking at KGlobalSettings::Private::applyGUIStyle() i see that it's already 
been changed to have QString() as the default for kde_overrideStyle on 
win/mac, iow, as i said:

> > but note that the part that touches kapplication.cpp uses 
> > kde_overrideStyle. it should not be doing that on win or mac; it should
> > instead default to QString() and if it is empty just not set it.

i just looked at the websvn link you gave (wasn't in front of a machine with 
source code at the time)

so yes, looks safe enough to change what KApplication is doing now that 
KGlobalSettings has been altered ...

Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Software

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
Url : 

More information about the Kde-windows mailing list