playground/libs/popupdropper/popupdropper

Patrick Spendrin ps_ml at gmx.de
Thu Jul 24 10:25:15 CEST 2008


Dan Meltzer schrieb:
> On Wed, Jul 23, 2008 at 9:05 PM, Pau Garcia i Quiles
> <pgquiles at elpauer.org> wrote:
>> Quoting Jeff Mitchell <kde-dev at emailgoeshere.com>:
>>
>>
>>> SVN commit 837166 by mitchell:
>>>
>>> a) Why did you change this -- you gave no email to the maintainer
>>> (me) before touching things
>>> b) Those lines that were in there already came straight from kdemacros
fixed in a wrong way
>>> c) You broke build
>>> d) You introduced KDE deps into a non-KDE library
>>>
>>> Reverting this crap.
This was only crap because of the KDE_IM/EXPORT
I have replaced it now, and if you have no other arguments than that it 
worked for you the other way as well, please leave it like that.
>>>
>>> CCMAIL: pgquiles at elpauer.org
>>>
>>>
>>>  M  +4 -9      PopupDropper_Export.h
>>>
>>>
>>> ---
>>> trunk/playground/libs/popupdropper/popupdropper/PopupDropper_Export.h
>>> #837165:837166
>>> @@ -20,15 +20,10 @@
>>>  #ifndef POPUPDROPPER_EXPORT_H
>>>  #define POPUPDROPPER_EXPORT_H
>>>
>>> -/* needed for KDE_EXPORT and KDE_IMPORT macros */
>>> -#include <kdemacros.h>
>>> -
>>> -#ifndef POPUPDROPPER_EXPORT
>>> -# if defined(MAKE_AMAROKPUD_LIB)
>>> -#   define POPUPDROPPER_EXPORT KDE_EXPORT
>>> -# else
>>> -#   define POPUPDROPPER_EXPORT KDE_IMPORT
>>> -# endif
>>> +#if defined(_WIN32) || defined(_WIN64)
>>> +    #define POPUPDROPPER_EXPORT __declspec(dllexport)
>>> +#else
>>> +    #define POPUPDROPPER_EXPORT __attribute__ ((visibility("default")))
>>>  #endif
>>>
>>>  #endif
> 


-- 
web:                 http://windows.kde.org
mailing list:        kde-windows at kde.org
irc:                 #kde-windows (irc.freenode.net)


More information about the Kde-windows mailing list