playground/libs/popupdropper/popupdropper

[Christian Ehrlicher]

Pau Garcia i Quiles schrieb:
>> ---   
>> trunk/playground/libs/popupdropper/popupdropper/PopupDropper_Export.h   
>> #837165:837166
>> @@ -20,15 +20,10 @@
>>  #ifndef POPUPDROPPER_EXPORT_H
>>  #define POPUPDROPPER_EXPORT_H
>>
>> -/* needed for KDE_EXPORT and KDE_IMPORT macros */
>> -#include <kdemacros.h>
>> -
>> -#ifndef POPUPDROPPER_EXPORT
>> -# if defined(MAKE_AMAROKPUD_LIB)
>> -#   define POPUPDROPPER_EXPORT KDE_EXPORT
>> -# else
>> -#   define POPUPDROPPER_EXPORT KDE_IMPORT
>> -# endif
>> +#if defined(_WIN32) || defined(_WIN64)
>> +    #define POPUPDROPPER_EXPORT __declspec(dllexport)
>> +#else
>> +    #define POPUPDROPPER_EXPORT __attribute__ ((visibility("default")))
>>  #endif
>>
>>  #endif
>>
> 
The correct way for non-kde apps is then:

------------------------------#
#include <qglobal.h>

#ifdef Q_WS_WIN
# if defined(MAKE_AMAROKPUD_LIB)
#  define POPUPDROPPER_EXPORT Q_DECL_EXPORT
# else
#  define POPUPDROPPER_EXPORT Q_DECL_IMPORT
# endif
#else
# define POPUPDROPPER_EXPORT Q_DECL_EXPORT
#endif


And if I would have asked all devs just because of this change (which 
was needed in a lot of places) ... hmmm



HTH
Christian

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 258 bytes
Desc: OpenPGP digital signature
Url : http://mail.kde.org/pipermail/kde-windows/attachments/20080724/9abb648f/attachment.pgp