[Kde-pim] [patch] kdepimlibs - KIO slaves simplified + windows fixes

Jarosław Staniek js at iidea.pl
Wed Jan 30 18:25:32 CET 2008


Allen Winter said the following, On 2008-01-30 16:52:
> On Wednesday 30 January 2008 08:00:46 Jarosław Staniek wrote:
>> For review;
>>
>> - sasl_client_init() and error message wrapped with common initSASL(),
>>     which on windows also calls sasl_set_path()
>> - in case of pop3, initSASL() call is moved after creation of
>> QCoreApplication because on win32 we use KGlobal::dirs()
>> - sieve: we need HAVE_LIBSASL2 for common.h
> 
> The patch looks ok to me.
> 
> I don't understand why the initSASL() stuff is
> needed on Windows, but I'm sure you know
> what you're doing.

I should have give more background.

Here's a function of sasl.h:

/* a simpler way to set plugin path or configuration file path
  * without the need to set sasl_getpath_t callback.
  *
  * This function can be called before sasl_server_init/sasl_client_init.
  */
LIBSASL_API int sasl_set_path (int path_type, char * path);

We're using the function to change the default C:\CMU\bin\sasl2
to KDEROOT/lib what is a target for installation of the cyrus-sasl package 
(performed by the KDE/Windows installer or emerge).

BTW, remaining question is: if we do not want to have cyrus-sasl config file 
in lib/ on windows (as it is defined in the patch), perhaps 
KDEROOT/share/config/sasl2/ would be better.

Is the config file (which is external to KDE itself) used at all by us?

-- 
regards / pozdrawiam, Jaroslaw Staniek
  Sponsored by OpenOffice Polska (http://www.openoffice.com.pl/en) to work on
  Kexi & KOffice (http://www.kexi.pl/en, http://www.koffice.org/kexi)
  KDE Libraries for MS Windows (http://windows.kde.org)



More information about the Kde-windows mailing list