KDE/kdelibs/kimgio

[Matt Rogers]

On Thursday 03 August 2006 23:39, you wrote:
> Matt Rogers schrieb:
> > SVN commit 569510 by mattr:
> >
> > MSVC doesn't like whatever is used to support TIFF, so disable it.
> >
> >  M  +2 -2      CMakeLists.txt
> >
> >
> > --- trunk/KDE/kdelibs/kimgio/CMakeLists.txt #569509:569510
> > @@ -126,7 +126,7 @@
> >  endif(OPENEXR_FOUND)
> >
> >
> > -if(TIFF_FOUND)
> > +if(TIFF_FOUND AND NOT MSVC)
> >      include_directories( ${TIFF_INCLUDE_DIR} )
> >      set(kimg_tiff_LIB_SRCS tiffr.cpp)
> >      kde4_add_plugin(kimg_tiff ${kimg_tiff_LIB_SRCS})
> > @@ -135,7 +135,7 @@
> >     
> > #kde4_install_libtool_file(${PLUGIN_INSTALL_DIR}/plugins/imageformats/
> > kimg_tiff ) install(TARGETS kimg_tiff  DESTINATION
> > ${PLUGIN_INSTALL_DIR}/plugins/imageformats/ ) install( FILES tiff.desktop
> > DESTINATION  ${SERVICES_INSTALL_DIR}/qimageioplugins/ )
> > -endif(TIFF_FOUND)
> > +endif(TIFF_FOUND AND NOT MSVC)
>
> Why do you disable tiff? It compiles fine here...
> Also I don't understand your other checkin - what's the problem
> including netsupp.h - I also had no problems with that.
>
> Christian

definitions in netsupp.h conflict with defintions found in an winsock api 
file, hence the exclusion of that file when compiling with MSVC 8 (VS Express 
2005).

With the tiff stuff, I get some error about passing locale_t instead of void* 
or something along those lines. Either way, these patches allow kdelibs to 
build for me in Win2K on MSVC 2005.
--
Matt