D25378: Get icon size from QStyle instead of KIconLoader

[Elvis Angelaccio]

elvisangelaccio added a comment.


  +1 but why only `archivemodel.cpp` ?
  
    $ git grep KIconLoader
    kerfuffle/extractiondialog.cpp:#include <KIconLoader>
    kerfuffle/extractiondialog.cpp:    m_ui->iconLabel->setPixmap(QIcon::fromTheme(QStringLiteral("archive-extract")).pixmap(IconSize(KIconLoader::Desktop), IconSize(KIconLoader::Desktop)));
    kerfuffle/propertiesdialog.cpp:#include <KIconLoader>
    kerfuffle/propertiesdialog.cpp:    m_ui->lblIcon->setPixmap(icon.pixmap(IconSize(KIconLoader::Desktop), IconSize(KIconLoader::Desktop)));
    part/archivemodel.cpp:#include <KIconLoader>
    part/archivemodel.cpp:                return m_entryIcons.value(e->fullPath(NoTrailingSlash)).pixmap(IconSize(KIconLoader::Small), IconSize(KIconLoader::Small), mode);
    part/arkviewer.cpp:#include <KIconLoader>
    part/arkviewer.cpp:    m_iconLabel->setPixmap(QIcon::fromTheme(mimeType.iconName()).pixmap(IconSize(KIconLoader::Small), IconSize(KIconLoader::Small)));
    part/infopanel.cpp:#include <KIconLoader>
    part/infopanel.cpp:    return QIcon::fromTheme(name).pixmap(IconSize(KIconLoader::Desktop), IconSize(KIconLoader::Desktop));
  
  If we also remove those, we could get rid of the KIconLoader dependency altogheter.

REPOSITORY
  R36 Ark

REVISION DETAIL
  https://phabricator.kde.org/D25378

To: nicolasfella, #ark, elvisangelaccio
Cc: kde-utils-devel, fbampaloukas, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20191125/9ec08b8b/attachment.html>