<table><tr><td style="">elvisangelaccio added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D25378">View Revision</a></tr></table><br /><div><div><p>+1 but why only <tt style="background: #ebebeb; font-size: 13px;">archivemodel.cpp</tt> ?</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="console" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);"><span style="color: #000080">$ git grep KIconLoader</span>
<span style="color: #808080">kerfuffle/extractiondialog.cpp:#include <KIconLoader></span>
<span style="color: #808080">kerfuffle/extractiondialog.cpp:    m_ui->iconLabel->setPixmap(QIcon::fromTheme(QStringLiteral("archive-extract")).pixmap(IconSize(KIconLoader::Desktop), IconSize(KIconLoader::Desktop)));</span>
<span style="color: #808080">kerfuffle/propertiesdialog.cpp:#include <KIconLoader></span>
<span style="color: #808080">kerfuffle/propertiesdialog.cpp:    m_ui->lblIcon->setPixmap(icon.pixmap(IconSize(KIconLoader::Desktop), IconSize(KIconLoader::Desktop)));</span>
<span style="color: #808080">part/archivemodel.cpp:#include <KIconLoader></span>
<span style="color: #808080">part/archivemodel.cpp:                return m_entryIcons.value(e->fullPath(NoTrailingSlash)).pixmap(IconSize(KIconLoader::Small), IconSize(KIconLoader::Small), mode);</span>
<span style="color: #808080">part/arkviewer.cpp:#include <KIconLoader></span>
<span style="color: #808080">part/arkviewer.cpp:    m_iconLabel->setPixmap(QIcon::fromTheme(mimeType.iconName()).pixmap(IconSize(KIconLoader::Small), IconSize(KIconLoader::Small)));</span>
<span style="color: #808080">part/infopanel.cpp:#include <KIconLoader></span>
<span style="color: #808080">part/infopanel.cpp:    return QIcon::fromTheme(name).pixmap(IconSize(KIconLoader::Desktop), IconSize(KIconLoader::Desktop));</span></pre></div>

<p>If we also remove those, we could get rid of the KIconLoader dependency altogheter.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R36 Ark</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D25378">https://phabricator.kde.org/D25378</a></div></div><br /><div><strong>To: </strong>nicolasfella, Ark, elvisangelaccio<br /><strong>Cc: </strong>kde-utils-devel, fbampaloukas, tctara<br /></div>