D21403: Fix progress info for CreateJob for non-CLI-plugins

Elvis Angelaccio noreply at phabricator.kde.org
Sun May 26 15:54:56 BST 2019


elvisangelaccio added a comment.


  > - Is this the correct way to solve the problem?
  > - Should this connection type be used for any of the other signals?
  
  We should double check it, but it's possible that `progress` is the only signal "normally" emitted by an AddJob.
  Btw I thought we were already using some `Qt::DirectConnection` elsewhere, but it seems we don't anymore.
  
  I also tried to add
  
    connect(archiveInterface(), &ReadOnlyArchiveInterface::progress, this, &CreateJob::onProgress);
  
  at the beginning of `CreateJob::doWork()`, without direct connection, but this only fixes the progress for libzip :/

REPOSITORY
  R36 Ark

REVISION DETAIL
  https://phabricator.kde.org/D21403

To: rthomsen, elvisangelaccio
Cc: kde-utils-devel, #ark, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20190526/8261c707/attachment.html>


More information about the Kde-utils-devel mailing list