D21403: Fix progress info for CreateJob for non-CLI-plugins

[Ragnar Thomsen]

rthomsen created this revision.
rthomsen added a reviewer: elvisangelaccio.
rthomsen added a project: Ark.
Herald added subscribers: Ark, kde-utils-devel.
rthomsen requested review of this revision.

REVISION SUMMARY
  Commit ce2f7f6690be1e5165ec1300affeabd5cc146e31 <https://phabricator.kde.org/R36:ce2f7f6690be1e5165ec1300affeabd5cc146e31> fixed progress info for `CreateJob` for the CLI-plugins. However, it still doesn't work for `libzipplugin` and `libarchiveplugin` (see bug 402824 <https://bugs.kde.org/show_bug.cgi?id=402824>). This seems to be caused by these plugins being run in a separate thread and the `progress` signal not reaching the slot in the receivers thread. This is fixed by using `Qt::DirectConnection` in the `connect` call.
  
  Questions:
  
  - Is this the correct way to solve the problem?
  - Should this connection type be used for any of the other signals?

TEST PLAN
  Create a large archive with `libzipplugin` and `libarchiveplugin` by using the `-t <archivename>` switch. Verify that progress info is working.

REPOSITORY
  R36 Ark

REVISION DETAIL
  https://phabricator.kde.org/D21403

AFFECTED FILES
  kerfuffle/jobs.cpp

To: rthomsen, elvisangelaccio
Cc: kde-utils-devel, #ark, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20190525/27e033c4/attachment.html>