D20615: bitset: Add bit number to tooltip

[Albert Astals Cid]

aacid added a comment.


  The on hover looks really great.
  
  Do you think we should also paint in "on hover" even if it's set when the mouse is over it? I'm conflicted

INLINE COMMENTS

> kcalc_bitset.cpp:95
>  				BitButton *const tmpBitButton = new BitButton(this);
> +				tmpBitButton->setToolTip(tr("Bit ") + QString::number(bitCounter));
>  				wordlayout->addWidget(tmpBitButton);

we don't use tr but i18n, this should be i18n("Bit %1", bitCounter)

REPOSITORY
  R353 KCalc

REVISION DETAIL
  https://phabricator.kde.org/D20615

To: athurh, aacid
Cc: cfeck, kde-utils-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20190510/1fd59f2e/attachment.html>