D19766: Improve performance of cliplugins

Rolf Eike Beer noreply at phabricator.kde.org
Tue Mar 19 22:58:47 GMT 2019


dakon added inline comments.

INLINE COMMENTS

> rthomsen wrote in cliinterface.cpp:815
> I didn't think this was necessary when using Qt's foreach loops on Qt container classes? AFAIK foreach prevents detaching...

Yes, you are right. Will become necessary if you switch to range based for loop ;)

> rthomsen wrote in cliinterface.cpp:964
> We loop over a QList. Isn't a foreach loop better suited for this container class?

Qt itself tries to get rid of them as much as possible, so I think they should possibly go away.

REPOSITORY
  R36 Ark

REVISION DETAIL
  https://phabricator.kde.org/D19766

To: rthomsen, elvisangelaccio
Cc: dakon, kde-utils-devel, #ark, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20190319/6b9ce47b/attachment.html>


More information about the Kde-utils-devel mailing list