D19766: Improve performance of cliplugins

[Ragnar Thomsen]

rthomsen marked 2 inline comments as done.
rthomsen added inline comments.

INLINE COMMENTS

> dakon wrote in cliinterface.cpp:781
> constLast(), not sure if you really save a lot if you additionally do the conversion to QLatin1String only once, but since you need it at multiple places it's likely no overhead to do so anyway.

I would rather handle this separately, since it's not really related to this diff.

> dakon wrote in cliinterface.cpp:815
> qAsConst to avoid detaching

I didn't think this was necessary when using Qt's foreach loops on Qt container classes? AFAIK foreach prevents detaching...

> dakon wrote in cliinterface.cpp:964
> range based for? Don't forget to put the list in a (const) variable to avoid that the iterators point to an already destroyed temporary.

We loop over a QList. Isn't a foreach loop better suited for this container class?

REPOSITORY
  R36 Ark

REVISION DETAIL
  https://phabricator.kde.org/D19766

To: rthomsen, elvisangelaccio
Cc: dakon, kde-utils-devel, #ark, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20190319/1a7ba063/attachment.html>