D13876: Display more readable tooltip text

[Harald Sitter]

sitter accepted this revision.
sitter added a comment.


  Looks good to land unless @sandsmark sees more issues.

INLINE COMMENTS

> andrewc wrote in widgetEvents.cpp:190
> I agree, but wouldn't that mean the translators would have to re-translate this string? I wonder if it's worth it

Oh, it's a pre-existing string. Yeah, they'd have to re-translate. Nevermind changing this then.

> andrewc wrote in summaryWidget.cpp:148
> I moved the i18n to this part:
> 
>   if (strcmp("used", m_focus->file()->name8Bit()) == 0) {
>       string = i18nc("Tooltip of used space on the partition, %1 is path, %2 is size", "%1\nUsed: %2",..
>   } else if (strcmp("free", m_focus->file()->name8Bit()) == 0) {
>       string = i18nc("Tooltip of free space on the partition, %1 is path, %2 is size", "%1\nFree: %2",..
> 
> My logic is the context will be less confusing to translators if they see used or free instead of another variable "%2".

Ah, perfect.

REVISION DETAIL
  https://phabricator.kde.org/D13876

To: andrewc, sandsmark, sitter
Cc: kde-utils-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20180726/f9e26a2c/attachment.html>